Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 563 563
Branches 174 174
=========================================
Hits 563 563 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 19187633189Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull Request Overview
This PR appears to be a maintenance and documentation update that includes:
- Updates to Ruby version (3.4.5 → 3.4.7)
- Documentation regeneration with updated timestamps
- Dependency management changes (removing some test dependencies, updating gem paths)
- Documentation formatting improvements (converting HTML line breaks to proper markdown)
- Addition of THREAT_MODEL.md to the gem files list
- Minor documentation clarifications and corrections
Reviewed Changes
Copilot reviewed 58 out of 63 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| oauth2.gemspec | Removed unused variable, updated dependencies, added THREAT_MODEL.md to gem files, removed commented development dependencies |
| lib/oauth2/strategy/assertion.rb | Wrapped code examples in backticks for better documentation rendering |
| lib/oauth2/access_token.rb | Wrapped code example in backticks for better documentation rendering |
| gemfiles/modular/x_std_libs/r2.4/libs.gemfile | Changed erb gemfile path from r2.4 to r2.6 |
| gemfiles/modular/optional.gemfile | Added addressable gem as optional dependency |
| gemfiles/modular/erb/r2.3/default.gemfile | Minor comment update removing "RubyGems.org" reference |
| gemfiles/modular/documentation.gemfile | Added yard-fence gem dependency |
| docs/* | Documentation regenerated with updated timestamps and formatting improvements |
| .tool-versions | Ruby version bumped from 3.4.5 to 3.4.7 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 77 out of 83 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,3 +1,3 @@ | |||
| eval_gemfile "../../erb/r2.4/v2.2.gemfile" | |||
| eval_gemfile "../../erb/r2.6/v2.2.gemfile" | |||
There was a problem hiding this comment.
The file is named r2.4/libs.gemfile but now references r2.6/v2.2.gemfile. This creates confusion about which Ruby version this gemfile targets. Either the file should be moved to r2.6/libs.gemfile or the path should remain r2.4/v2.2.gemfile. If this is intentional due to erb compatibility issues, add a comment explaining why r2.4 uses the r2.6 erb gemfile.
Minimum allowed line rate is |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 77 out of 83 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix docs site generation (Markdown => YARD with Kramdown => HTML) when braces are used within code fences.
Fixes #688